Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eda notebook #1283

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Eda notebook #1283

wants to merge 4 commits into from

Conversation

dmfalke
Copy link
Member

@dmfalke dmfalke commented Nov 21, 2024 •
edited
Loading

Supports #1273

@dmfalke
checkpoint
34ca45e
@dmfalke
Checkpoint
e162ad7 
- Basics of cell types
- Persistence
- Iterate on styling
dmfalke
dmfalke commented Nov 21, 2024
View reviewed changes
packages/libs/eda/src/lib/core/components/VariableLink.tsx
@@ -70,12 +70,12 @@ export const VariableLink = forwardRef(
tabIndex={0}
style={finalStyle}
onKeyDown={(event) => {
event.preventDefault();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was breaking keyboard accessibility.

@dmfalke
Checkpoint
d1db6f9 
- Expose some coreui theme values as custom css properties
- Replace ExpandablePanel with <details>
- Replace SCSS file with CSS file
@dmfalke
Expose all coreui color definitions as css custom properties.
d3d6966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmfalke